Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle people address from ro-crate json #465

Open
jorgitogb opened this issue Oct 27, 2024 · 1 comment
Open

handle people address from ro-crate json #465

jorgitogb opened this issue Oct 27, 2024 · 1 comment
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature

Comments

@jorgitogb
Copy link

Describe the bug
using JsonController.Investigation().from_rocrate_json_string() only can handle address as a str
To Reproduce
Steps to reproduce the behavior:

A valid schema.org person:

{
"@context": "http://schema.org",
"@type": "Person",
"address": {
"@type": "PostalAddress",
"addressCountry": "Germany",
"addressLocality": "Musterstadt",
"postalCode": "12345",
"streetAddress": "Maxstraße 42"
},
"familyName": "Musterfrau",
"givenName": "Erika",
"name": "Erika Musterfrau"
}

ARC compatible version:

{
"@context": {
"@vocab": "http://schema.org/"
},
"@type": "Person",
"address": "Maxstraße 42, 12345 Musterstadt, Germany"
"familyName": "Musterfrau",
"givenName": "Erika",
}

Expected behavior
handle str and obj representation of an address

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Oct 27, 2024
@HLWeil HLWeil added Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature and removed Status: Needs Triage This item is up for investigation. labels Oct 28, 2024
@HLWeil
Copy link
Member

HLWeil commented Oct 28, 2024

Hey @jorgitogb,
thanks for bringing this issue up. This was also something I discussed with @Zalfsten, and it's definitely something that will be handled in ARCtrl.

We're currently working on a big restructure of the whole parsing and handling of the ARC RO-Crate representation. Until that is finished (Hopefully this year), it would be nice if you could handle this on your side (e.g. put the json object as a blob into a string).

If there's progress on this issue I will update you here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature
Projects
Status: No status
Development

No branches or pull requests

2 participants