Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arc_isa.json/arc_json have wrong format #6

Closed
kMutagene opened this issue Aug 28, 2024 · 0 comments · Fixed by #8
Closed

arc_isa.json/arc_json have wrong format #6

kMutagene opened this issue Aug 28, 2024 · 0 comments · Fixed by #8
Assignees
@HLWeil
Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.

Comments

@kMutagene
Copy link
Member

kMutagene commented Aug 28, 2024 •
edited
Loading

see

arc-export/src/arc-export/Writers.fs

Lines 23 to 27 in b0f7a95

let write_isa_json (outDir: string) (arc: ARC) =
let inv = arc.ISA |> Option.get
let isa_json = inv.ToROCrateJsonString(2)
let isa_json_path = Path.Combine(outDir, isa_json_filename)
File.WriteAllText(isa_json_path, isa_json)

output format is ROCrate although it should not
@kMutagene kMutagene added the Status: Needs Triage This item is up for investigation. label Aug 28, 2024
@HLWeil HLWeil added Type: Bug Something is not working, and it is confirmed by maintainers to be a bug. and removed Status: Needs Triage This item is up for investigation. labels Aug 28, 2024
@HLWeil HLWeil mentioned this issue Aug 28, 2024
Merged
@HLWeil HLWeil closed this as completed in #8 Aug 28, 2024
@github-project-automation github-project-automation bot moved this to Done in ARCStack Aug 28, 2024
@kMutagene kMutagene mentioned this issue Aug 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HLWeil HLWeil

Labels
Type: Bug Something is not working, and it is confirmed by maintainers to be a bug.
Projects
ARCStack
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix isa-writer writing RO-Crate nfdi4plants/arc-export
2 participants
@HLWeil @kMutagene