New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace node:punycode with punycode.js due to deprecate #171

Merged

nfroidure merged 1 commit into nfroidure:main from ianlauyin:punycode

Sep 7, 2024

Contributor

ianlauyin commented Sep 6, 2024

Fixes #

Replacing node:punycode with punycode.js due to
Ref: https://nodejs.org/api/punycode.html

Code quality

I made some tests for my changes
I added my name in the
contributors
field of the package.json file.

License

To get your contribution merged, you must check the following.

I read the project license in the LICENSE file
I agree with publishing under this project license

Join

I wish to join the core team
I agree that with great powers comes responsibilities
I'm a nice person


          refactor: replace node:punycode with punycode

ba9d4e4

nfroidure merged commit cd86ee5 into nfroidure:main

1 check passed

Contributor

andersk commented Nov 7, 2024

We can actually remove punycode completely:

Replace punycode dependency with string iteration #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet