Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown only if CLOSE has been set to xprt->xp_flags #318

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Shutdown only if CLOSE has been set to xprt->xp_flags #318

merged 1 commit into from
Jan 28, 2025

Conversation

rojingeorge
Copy link

@rojingeorge rojingeorge commented Aug 27, 2024 •
edited
Loading

This commit fixes a Hung issue, when we try to mount using NFSv3.

FDs getting shutdown/closed was causing issues post rearming the events...This got opened up as part of the changes made in 16daff0c1999c158dec9ad026902401b8ea7a64f...Old check put was removed in this patch...If the above changes were reverted, then all works fine...

27/08/2024 05:26:26Z : 271645[::ffff:10.46.185.45] [io_10] nfs_rpc_process_request :DISP :DEBUG :Request from ::ffff:10.46.185.45 for Program 100005, Version 3, Function 0 has xid=817545599

...

27/08/2024 05:26:26Z : 271645[::ffff:10.46.185.45] [io_10] rpc :TIRPC :F_DBG :xdr_reply_encode:109 SUCCESS
27/08/2024 05:26:26Z : 271645[none] [io_11] rpc :TIRPC :F_DBG :Trace svc_ref_it() 0x7f0c25279500 fd 0 fd_send 0 xp_refcnt 2 af 0 port 4294967295 xp_flags  @svc_dg_xprt_zalloc:108
27/08/2024 05:26:26Z : 271645[::ffff:10.46.185.45] [io_10] rpc :TIRPC :F_DBG :svc_dg_reply: 0x7f0c261afa80 fd 17 err 32 sendmsg failed (will set dead)
27/08/2024 05:26:26Z : 271645[none] [io_11] rpc :TIRPC :F_DBG :svc_rqst_rearm_events:198 locking
27/08/2024 05:26:26Z : 271645[::ffff:10.46.185.45] [io_10] complete_request :DISP :DEBUG :NFS DISPATCHER: FAILURE: Error while calling svc_sendreply on a new request. rpcxid=817545599 socket=17 function:MNT_NULL client:::ffff:10.46.185.45 program:100005 nfs version:3 proc:0 errno: 32
27/08/2024 05:26:26Z : 271645[none] [io_11] rpc :TIRPC :F_DBG :svc_rqst_rearm_events_locked: xprt 0x7f0c2d869000 fd 17 ev_flags ADDED_RECV
27/08/2024 05:26:26Z : 271645[::ffff:10.46.185.45] [io_10] rpc :TIRPC :F_DBG :Trace svc_destroy_it() 0x7f0c261afa80 fd 17 fd_send 0 xp_refcnt 3 af 10 port 716 xp_flags  INITIAL INITIALIZED DESTROYING @complete_request:1323
27/08/2024 05:26:26Z : 271645[none] [io_11] rpc :TIRPC :F_DBG :svc_rqst_rearm_events_locked: 0x7f0c2d869000 fd 17 xp_refcnt 6 sr_rec 0x7f0c31cb76c0 evchan 8 ev_refcnt 5 epoll_fd 9 control fd pair (7:8) rearm event 0x7f0c2d869528
27/08/2024 05:26:26Z : 271645[none] [io_11] rpc :TIRPC :F_DBG :svc_rqst_rearm_events:202 unlocking @svc_rqst_rearm_events:198
27/08/2024 05:26:26Z : 271645[::ffff:10.46.185.45] [io_10] rpc :TIRPC :F_DBG :Trace svc_release_it() 0x7f0c261afa80 fd 17 fd_send 0 xp_refcnt 2 af 10 port 716 xp_flags  INITIAL INITIALIZED DESTROYING @complete_request:1323
27/08/2024 05:26:26Z : 271645[none] [io_11] rpc :TIRPC :F_DBG :svc_dg_rendezvous: 0x7f0c25279500 fd 17 Bad message sa_family is 0xffff




27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_14] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff
27/08/2024 04:53:15Z : 271645[none] [io_13] rpc :TIRPC :F_DBG :svc_dg_rendezvous: Bad message sa_family is 0xffff

@ffilz ffilz mentioned this pull request Nov 21, 2024
Open
@dang
Copy link
Collaborator

dang commented Nov 22, 2024

Please fix the conflicts

@oliviergaraud oliviergaraud mentioned this pull request Nov 28, 2024
Open
drieber
drieber reviewed Jan 22, 2025
View reviewed changes
Copy link

@drieber drieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being reviewed on gerrithub? I can't figure out how to get a link to this in gerrithub. What is the status of this PR?

@ffilz
Copy link
Member

ffilz commented Jan 23, 2025

Is this being reviewed on gerrithub? I can't figure out how to get a link to this in gerrithub. What is the status of this PR?

ntirpc patches are submitted by github pull request and reviewed here.

@drieber
Copy link

drieber commented Jan 23, 2025

Ok. What is the status of this PR? We seem to be running into the issue reported here (Bad message sa_family is 0xffff) during a test that uses NFSv3. Somebody reported this PR solves the problem.

@rojingeorge
Copy link
Author

rojingeorge commented Jan 23, 2025 •
edited
Loading

Yes, this fixes such bugs for sure...

Apologies, I missed to follow up on this...
This PR was not merged on time, delayed for some reason and then it started getting merge conflicts - since I didn't have had a setup to revalidate the fix, i never reworked :-(

rojingeorge
rojingeorge commented Jan 23, 2025
View reviewed changes
Copy link
Author

@rojingeorge rojingeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks fine...please help to merge it in... @ffilz @dang
cc: @drieber

@ffilz ffilz added Ready and removed Need Info labels Jan 24, 2025
@dang dang merged commit a392d47 into nfs-ganesha:next Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drieber drieber drieber left review comments

@dang dang dang approved these changes

@ffilz ffilz ffilz approved these changes

Assignees
No one assigned
Labels
bug Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rojingeorge @dang @ffilz @drieber