Skip to content

Commit

Permalink
Remove typescript ^4.8 in workspace subdirectories so entire project …
Browse files Browse the repository at this point in the history
…uses one typescript version (5.3.2)

We came across this while working on ngi-nix/ngipkgs#164.
While not strictly necessary for that task, it seemed like it was unintentional
that the project was depending on different versions of typescript (PR with original
upgrade is atomicdata-dev#710), so
I removed typescript in the various subdirectories so they all depend
on the same version as root.

- Edit tsconfig.build.json to fix the following error
  `TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'.`

- All the removed packages from pnpm-lock.yaml are duplicate entries
  • Loading branch information
albertchae committed Mar 6, 2024
1 parent 5e3004c commit a79f8c6
Show file tree
Hide file tree
Showing 5 changed files with 60 additions and 138 deletions.
3 changes: 0 additions & 3 deletions browser/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
"chalk": "^5.3.0",
"prettier": "3.0.3"
},
"devDependencies": {
"typescript": "^4.8"
},
"description": "",
"license": "MIT",
"name": "@tomic/cli",
Expand Down
1 change: 0 additions & 1 deletion browser/lib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"@tomic/cli": "workspace:*",
"@types/fast-json-stable-stringify": "^2.1.0",
"chai": "^4.3.4",
"typescript": "^4.8",
"whatwg-fetch": "^3.6.2"
},
"files": [
Expand Down
Loading

0 comments on commit a79f8c6

Please sign in to comment.