Skip to content

Commit

Permalink
Merge pull request #176 from ngi-nix/nix-flake-show-pr-comment-diff
Browse files Browse the repository at this point in the history
ci: Remove `nix flake show` diff generation

the cost/benefit ratio is too high:
- Complex custom implementation.
- Spams PR comments.
- GitHub's change overview is good enough (and will be even better with an improved directory structure).
- Adds complexity to permissions.
  • Loading branch information
fricklerhandwerk authored Apr 12, 2024
2 parents 84e9848 + 66ac044 commit 8992a02
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions .github/workflows/pull_request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,4 @@ jobs:
if: ${{ github.event.pull_request.head.repo.fork }}
with:
upstream-cache: https://ngi.cachix.org/
- id: flake-show-diff
name: Obtain `nix flake show` output
run: |
shopt -s expand_aliases
alias show="nix flake show --all-systems"
alias filter="nix run nixpkgs#ansifilter | tail -n +2"
alias short="git rev-parse --short"
git fetch origin ${GITHUB_BASE_REF}:${GITHUB_BASE_REF}
if diff -U 1024 \
--label "$(short $GITHUB_BASE_REF) $GITHUB_BASE_REF" <(show ".?rev=$(git rev-parse ${GITHUB_BASE_REF})" | filter) \
--label "$(short HEAD) $GITHUB_HEAD_REF" <(show | filter) \
>> diff
then
echo 'output=No difference in `nix flake show`.' >> "$GITHUB_OUTPUT"
else
echo -e 'output<<EOF\n<details><summary>Difference in <code>nix flake show</code>.</summary>\n\n```diff' >> "$GITHUB_OUTPUT"
cat diff >> "$GITHUB_OUTPUT"
echo -e '```\n</details>\nEOF' >> "$GITHUB_OUTPUT"
fi
- uses: thollander/actions-comment-pull-request@v2
with:
message: ${{ steps.flake-show-diff.outputs.output }}
- run: nix ${{ runner.debug && '--debug --print-build-logs' }} flake check

0 comments on commit 8992a02

Please sign in to comment.