Add support for large NGINX config file sizes #1053

dhurley · 2025-04-18T16:37:14Z

Add support for file chunking when uploading and downloading NGINX config from a management plane.

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING document
I have run make install-tools and have attached any dependency changes to this pull request
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
If applicable, I have updated any relevant documentation (README.md)
If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

internal/file/file_manager_service_test.go

internal/file/file_manager_service.go

dhurley added 2 commits April 17, 2025 16:07

Implement file chunking

8f758b2

Add file chunk size config parameter. Add unit tests.

d06517c

dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Apr 18, 2025

dhurley self-assigned this Apr 18, 2025

dhurley requested a review from a team as a code owner April 18, 2025 16:37

github-actions bot added the chore Pull requests for routine tasks label Apr 18, 2025

aphralG reviewed Apr 22, 2025

View reviewed changes

internal/file/file_manager_service.go Outdated Show resolved Hide resolved

dhurley added 4 commits April 28, 2025 11:22

Merge branch 'v3' into add-file-chuncking

67dbdbf

Clean up file manager service

4968d7b

Clean up file manager service tests

5508282

Add max file size config param

29a3e4d

sean-breen approved these changes May 2, 2025

View reviewed changes

aphralG added 5 commits May 7, 2025 11:56

merge v3

24dbad6

fix unit tests

f3555e2

integration tests

97b9c1f

retry tests

793d11b

fix unit tests

f8b93ca

Provide feedback