Skip to content

Add setting config path from NGINX process #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 8, 2025
Merged

Add setting config path from NGINX process #1073

merged 3 commits into from
May 8, 2025

Conversation

john-david3
Copy link

Proposed changes

  • Set config path attribute when nginx -c <filepath> is used
  • Created new unit test for getting the config path from the command

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@john-david3 john-david3 self-assigned this May 1, 2025
@john-david3 john-david3 requested a review from a team as a code owner May 1, 2025 12:35
@github-actions github-actions bot added the chore Pull requests for routine tasks label May 1, 2025
@john-david3 john-david3 added the v3.x Issues and Pull Requests related to the major version v3 label May 8, 2025
@john-david3 john-david3 merged commit 55e4cbc into v3 May 8, 2025
20 checks passed
@john-david3 john-david3 deleted the add-dynamic-config-path branch May 8, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigell craigell craigell approved these changes

@CVanF5 CVanF5 CVanF5 approved these changes

@aphralG aphralG aphralG approved these changes

Assignees

@john-david3 john-david3

Labels
chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@john-david3 @craigell @CVanF5 @aphralG