Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updates to contributions #312

Merged
merged 2 commits into from
Mar 25, 2025
Merged

fix: Updates to contributions #312

merged 2 commits into from
Mar 25, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Mar 24, 2025

Proposed changes

Changes:

  • Fixed link (updated title)
  • Removed N Agent from list of docs in other repos (did I forget others?)
  • Linked to good example of "how to say no"

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang self-assigned this Mar 24, 2025
@mjang mjang marked this pull request as ready for review March 24, 2025 18:01
@mjang mjang requested a review from a team as a code owner March 24, 2025 18:01
@github-actions github-actions bot added the process documentation Documentation related to how the repository or documention itself is managed. label Mar 24, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/312/

ADubhlaoich
ADubhlaoich approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed N Agent from list of docs in other repos (did I forget others?)

No, I think that's it. Unit is pending some kind of decision for consolidation IIRC, NIC is blocked by some automation.

@mjang mjang merged commit c7234a7 into main Mar 25, 2025
9 checks passed
@mjang mjang deleted the update-contributing-guide branch March 25, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@travisamartin travisamartin travisamartin approved these changes

Assignees

@mjang mjang

Labels
process documentation Documentation related to how the repository or documention itself is managed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjang @ADubhlaoich @travisamartin