Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenerateVirtualServer upstreams config refactor #7264

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 4, 2025

Proposed changes

Pull common code into one function

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 4, 2025 13:51
@github-actions github-actions bot added the go Pull requests that update Go code label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 81.03448% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.78%. Comparing base (3f73934) to head (cea91f2).

Files with missing lines Patch % Lines
internal/configs/virtualserver.go 81.03% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7264      +/-   ##
==========================================
+ Coverage   52.72%   52.78%   +0.05%     
==========================================
  Files          89       89              
  Lines       20843    20845       +2     
==========================================
+ Hits        10989    11002      +13     
+ Misses       9396     9387       -9     
+ Partials      458      456       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Status: Todo ☑
Development

Successfully merging this pull request may close these issues.

3 participants