Skip to content

docs: NIC+NAP wafv5 install guide perm fix #7760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged

Conversation

javorszky
Copy link
Contributor

Closes #7757

  • Use /tmp folder on both the host and the docker image when compiling the waf policy bundle due to file permission handling differences between docker engine and docker desktop
  • Update the installation guide to reflect the new location of the waf policy bundle and downloaded source JSON

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Closes #7757

* Use `/tmp` folder on both the host and the docker image when compiling
  the waf policy bundle due to file permission handling differences
  between docker engine and docker desktop
* Update the installation guide to reflect the new location of the
  waf policy bundle and downloaded source JSON
@javorszky javorszky requested review from a team as code owners May 7, 2025 14:35
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label May 7, 2025
Copy link

github-actions bot commented May 7, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7760/

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label May 7, 2025
@javorszky javorszky enabled auto-merge (squash) May 7, 2025 16:00
@javorszky javorszky merged commit fb44688 into main May 7, 2025
35 of 51 checks passed
@javorszky javorszky deleted the gabor/issue-7757-docs-fix branch May 7, 2025 16:02
nginx-bot pushed a commit that referenced this pull request May 7, 2025
* docs: NIC+NAP wafv5 install guide perm fix

Closes #7757

* Use `/tmp` folder on both the host and the docker image when compiling
  the waf policy bundle due to file permission handling differences
  between docker engine and docker desktop
* Update the installation guide to reflect the new location of the
  waf policy bundle and downloaded source JSON

* Change the destination of an mv to /Users/g.javorszky/Projects/NIC/kubernetes-ingress-docs instead of .

* Fix a typo for the downloaded file name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: napv5 + nic install doc fails for docker engine
4 participants