-
Notifications
You must be signed in to change notification settings - Fork 2k
docs: NIC+NAP wafv5 install guide perm fix #7760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #7757 * Use `/tmp` folder on both the host and the docker image when compiling the waf policy bundle due to file permission handling differences between docker engine and docker desktop * Update the installation guide to reflect the new location of the waf policy bundle and downloaded source JSON
✅ Deploy Preview will be available once build job completes!
|
…bernetes-ingress-docs instead of .
ADubhlaoich
approved these changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
vepatel
approved these changes
May 7, 2025
AlexFenlon
approved these changes
May 7, 2025
nginx-bot
pushed a commit
that referenced
this pull request
May 7, 2025
* docs: NIC+NAP wafv5 install guide perm fix Closes #7757 * Use `/tmp` folder on both the host and the docker image when compiling the waf policy bundle due to file permission handling differences between docker engine and docker desktop * Update the installation guide to reflect the new location of the waf policy bundle and downloaded source JSON * Change the destination of an mv to /Users/g.javorszky/Projects/NIC/kubernetes-ingress-docs instead of . * Fix a typo for the downloaded file name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
needs cherry pick
Cherry pick this PR into a release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7757
/tmp
folder on both the host and the docker image when compiling the waf policy bundle due to file permission handling differences between docker engine and docker desktopChecklist
Before creating a PR, run through this checklist and mark each as complete.