Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added footer to UserProfile.jsx and removed footer from Events.jsx #1169

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

Yash-Sajwan24
Copy link
Contributor

@Yash-Sajwan24 Yash-Sajwan24 commented Nov 4, 2023

closes #1160

👷🏻 Changes made

added footer to UserProfile and removed footer from Events

I have executed two operations:

  • I eliminated the footer from src/pages/Event/AllEvents/Events.jsx due to its impending launch.
  • I included the footer in src/pages/User/UserProfile.jsx to ensure that the logged-in user can view the footer within their profile.

Summary by CodeRabbit

  • Refactor
    • The Footer component has been removed from the Events page and added to the UserProfile page for improved user experience.

Copy link

coderabbitai bot commented Nov 4, 2023

Walkthrough

The changes made involve the relocation of the Footer component from the Events page to the UserProfile page. This means that the Footer component is no longer rendered on the Events page, but is now rendered on the UserProfile page instead.

Changes

File Path Summary
.../Event/AllEvents/Events.jsx The Footer component was removed from this file, both from the import statements and the JSX rendering.
.../User/UserProfile.jsx The Footer component was added to this file, both in the import statements and at the end of the UserProfile component.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Nov 4, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Yash-Sajwan24, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

coderabbitai[bot]

This comment was marked as outdated.

Copy link

This pull request has been deployed to Vercel.

Latest commit: 43463d2
✅ Preview: https://milan-nuuplne3w-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/7yh649Fj9THqviDdiFB4VPoZG8yW

View Workflow Logs

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🎉

The changes look good to me and will be merged soon.

Do follow Tamal for more Opensource fun projects and don't forget to drop a star so that you get updated about our latest releases (we will tag you and mention your work) and also a shoutout on social media (LinkedIn and Twitter) !

Happy Opensource 🚀.

@tamalCodes tamalCodes added status: ready ✅ This PR has passed all the checks and is now ready to be merged. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Nov 17, 2023
@tamalCodes tamalCodes merged commit 7d2e967 into ngoworldcommunity:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: ready ✅ This PR has passed all the checks and is now ready to be merged.
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

Bug: the shop portal and user profile are missing the footer
2 participants