-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rating and feedback system #1202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @KhushiAgarwal22, thank you for raising a pull request.
Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.
Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.
Give us a ⭐ to show some support
Happy OpenSource 🚀
I wanted it to be assigned under JWOC'24. The label to mr is showing of hackotober fest.Please could you change it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there it looks like there has been some misunderstanding about what I exactly wanted about the rating system.
I do not want any kind of rating for my website because that doesn't even make any sense what I can instead use is a rating system for all the different clubs that we currently have so here are the things that we might want to do for this particular component.
- The events can be rated so we can add a component to the events but since we do not have events as of now that can be skipped next slide
- The clubs can also have some ratings but instead of ratings we can make it much more sensible by adding a proper testimonials section here's how we can do it:
- Write beside the heading we can have a button which in turn would open a modal.
- That modal would have components as follows:
We do have a custom modal component which can be used for the same. Do take a look. Try and make the website responsive, and I guess we can add the backend later on.
Screenshots of changes made- |
This pull request has been deployed to Vercel.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align-items: center; | ||
width: 100%; | ||
} | ||
#upload{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use class based styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename the folder t Feedback
instead of Feedback System
okay sir will fix it. |
No need to call me "sir" or anything similar - Tamal would be enough ! |
![]() Is the UI fine now?? |
|
Found the file but not visible when open the website through npm run dev. |
Yes the UI looks good, let's push these ! |
I have added the button in clubsProfile.jsx. |
hi @tamalCodes , could you please help me fix the issue. I am not able to understand why deployment is failing. |
Hi @KhushiAgarwal22 , i think you might need to pull some latest changes from the |
Let's catch up 🙋🏻♂️Hi there, it has been a while since we last had a conversation so I wanted to know if you are still working on this. Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at [email protected] |
Notice 🚩Hi there, unfortunately, I will have to close this Issue/PR, as this issue/PR has been inactive for quite a while and there's no work going on for the same. There might be more Issues/PR that are waiting for this to be completed - so it is better to pace things up. I generally spend/wait for 3 weeks before marking any issue as stale and closing it. If you think that this is a mistake, please drop an email at [email protected], and we will get back to you. Regards, |
closes #1200
👷🏻 Changes made
Added a 5-star rating system along with user feedback which can be used for each event's feedback of user and could be saved in database. Right now as discussed , have added the frontend part of the feature.
📸 Screenshots