Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rating and feedback system #1202

Closed
wants to merge 5 commits into from

Conversation

KhushiAgarwal22
Copy link

@KhushiAgarwal22 KhushiAgarwal22 commented Jan 28, 2024

closes #1200

👷🏻 Changes made

Added a 5-star rating system along with user feedback which can be used for each event's feedback of user and could be saved in database. Right now as discussed , have added the frontend part of the feature.

📸 Screenshots

Screenshot 2024-01-28 173046 Screenshot 2024-01-28 173054

@github-actions github-actions bot added hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 💡 feature This generally contains addition/changes to features. labels Jan 28, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @KhushiAgarwal22, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@github-actions github-actions bot added the deployed This PR has been deployed to Vercel for testing. label Jan 28, 2024
@KhushiAgarwal22
Copy link
Author

I wanted it to be assigned under JWOC'24. The label to mr is showing of hackotober fest.Please could you change it.
@tamalCodes

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there it looks like there has been some misunderstanding about what I exactly wanted about the rating system.

I do not want any kind of rating for my website because that doesn't even make any sense what I can instead use is a rating system for all the different clubs that we currently have so here are the things that we might want to do for this particular component.

  • The events can be rated so we can add a component to the events but since we do not have events as of now that can be skipped next slide
  • The clubs can also have some ratings but instead of ratings we can make it much more sensible by adding a proper testimonials section here's how we can do it:

image

  • Write beside the heading we can have a button which in turn would open a modal.
  • That modal would have components as follows:
    • A heading that says Share your feedback
    • After that, we can have a form that looks like this
    • image
    • And finally a submit button.

We do have a custom modal component which can be used for the same. Do take a look. Try and make the website responsive, and I guess we can add the backend later on.

index.html Outdated Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
src/assets/data/routesConfig.jsx Outdated Show resolved Hide resolved
src/components/Navbar/Navbar.jsx Outdated Show resolved Hide resolved
@tamalCodes tamalCodes added JWOC hard status: need changes 🚧 Changes have been requested for these PRs and removed hacktoberfest-accepted This PR is accepted for Hacktoberfest. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jan 29, 2024
@KhushiAgarwal22
Copy link
Author

KhushiAgarwal22 commented Jan 29, 2024

Screenshots of changes made-
Please have a look @tamalCodes
Screenshot 2024-01-30 002726
Screenshot 2024-01-30 002736
Screenshot 2024-01-30 002742

Copy link

This pull request has been deployed to Vercel.

Latest commit: cfaf09f
✅ Preview: https://milan-beta-334u53jb5-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan-beta/7jEmjBWwvBkv7PsCtmDG1HekT8mX

View Workflow Logs

Copy link
Member

@tamalCodes tamalCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  • The button needs to be here, so that I can leave feedback for each clubs, please remove it from the clubs page.
  • Match the UI with the image that I ave attached below, the font can be poppins.

image

  • Fix the UI too, it is looking disoriented.

align-items: center;
width: 100%;
}
#upload{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use class based styles

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the folder t Feedback instead of Feedback System

src/components/Feedback system/Feedback.jsx Outdated Show resolved Hide resolved
src/components/Feedback system/upload.jpg Outdated Show resolved Hide resolved
src/pages/Club/AllClubs/Clubs.jsx Outdated Show resolved Hide resolved
src/pages/Club/AllClubs/Clubs.jsx Outdated Show resolved Hide resolved
src/components/Feedback system/Feedback.jsx Outdated Show resolved Hide resolved
@KhushiAgarwal22
Copy link
Author

okay sir will fix it.
@tamalCodes

@tamalCodes
Copy link
Member

okay sir will fix it. @tamalCodes

No need to call me "sir" or anything similar - Tamal would be enough !

@KhushiAgarwal22
Copy link
Author

Screenshot 2024-01-30 140555

Is the UI fine now??
Also I am unable to locate individual club on beta branch where you have asked to add the button. Please help me
@tamalCodes

@tamalCodes
Copy link
Member

Hi @KhushiAgarwal22

  • The file would be this one right here
  • The UI needs to be improved. I have shared the image please look at that.
  • The BG can be full white
  • Remove the dropdown feature
  • Font for all would be Poppins
  • Make sure the BG is not scrollable while the modal is open.

@KhushiAgarwal22
Copy link
Author

Is UI fine now?
image

Found the file but not visible when open the website through npm run dev.
@tamalCodes

@tamalCodes
Copy link
Member

Yes the UI looks good, let's push these !

@KhushiAgarwal22
Copy link
Author

I have added the button in clubsProfile.jsx.
@tamalCodes

@KhushiAgarwal22
Copy link
Author

hi @tamalCodes , could you please help me fix the issue. I am not able to understand why deployment is failing.

@tamalCodes
Copy link
Member

tamalCodes commented Feb 5, 2024

Hi @KhushiAgarwal22 , i think you might need to pull some latest changes from the beta branch. Along with that also please fix the conflicts that are there. I'll merge it asap then.

@tamalCodes
Copy link
Member

Let's catch up 🙋🏻‍♂️

Hi there, it has been a while since we last had a conversation so I wanted to know if you are still working on this. Please drop a reply shortly so that we know you are active, feel free to convey any problem you face in the comments, or mail me at [email protected]

@tamalCodes
Copy link
Member

Notice 🚩

Hi there, unfortunately, I will have to close this Issue/PR, as this issue/PR has been inactive for quite a while and there's no work going on for the same.

There might be more Issues/PR that are waiting for this to be completed - so it is better to pace things up. I generally spend/wait for 3 weeks before marking any issue as stale and closing it.

If you think that this is a mistake, please drop an email at [email protected], and we will get back to you.

Regards,
Team Milan.

@tamalCodes tamalCodes closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed This PR has been deployed to Vercel for testing. 💡 feature This generally contains addition/changes to features. hard JWOC status: need changes 🚧 Changes have been requested for these PRs
Projects
Status: Merged/Discarded
Development

Successfully merging this pull request may close these issues.

2 participants