Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Exercise sending response headers #298

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

amirlivneh
Copy link
Contributor

No description provided.

auto value = fuzzed_data_provider->ConsumeRandomLengthString();

const nghttp3_nv nva[] = {
MAKE_NV(name.c_str(), value.c_str()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name.c_str() is a pointer to char, and sizeof(...) returns the size of pointer, which is not what you want here.
MAKE_NV is intended for string literals.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed.

@tatsuhiro-t tatsuhiro-t merged commit 77b88de into ngtcp2:main Jan 1, 2025
18 checks passed
@tatsuhiro-t
Copy link
Member

Thank you for PR. Merged now.

@tatsuhiro-t tatsuhiro-t added this to the v1.8.0 milestone Jan 1, 2025
@amirlivneh amirlivneh deleted the fuzz-response branch January 1, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants