Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant condition in nghttp3_conn_submit_request() #316

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

amirlivneh
Copy link
Contributor

The preceding assertion for nghttp3_client_stream_bidi() ensures that nghttp3_stream_uni() always returns false.

The preceding assertion for nghttp3_client_stream_bidi() ensures that nghttp3_stream_uni() always returns false.
@tatsuhiro-t tatsuhiro-t added this to the v1.8.0 milestone Jan 14, 2025
@tatsuhiro-t tatsuhiro-t merged commit 00e53bf into ngtcp2:main Jan 14, 2025
18 checks passed
@tatsuhiro-t
Copy link
Member

Thank you for PR. Merged now.

@amirlivneh amirlivneh deleted the redundant-condition branch January 14, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants