Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add a period of time? #175

Closed
guiwb opened this issue Aug 7, 2018 · 8 comments · Fixed by #189
Closed

How to add a period of time? #175

guiwb opened this issue Aug 7, 2018 · 8 comments · Fixed by #189
Labels
Enhancement Enhance performance or improve usability of original features. Question

Comments

@guiwb
Copy link

guiwb commented Aug 7, 2018

Version

1.6

Development Environment

Windows Chrome

Current Behavior

  • Currently the weekly calendar is shown from 1am to 23pm.

  • And I can create events every 30 minutes.

Expected Behavior

  • I would like to select this period, for example from 8am until 20pm.

  • And I'd like to force the creation of events every 1 hour

Thank you for listening,
I await an answer.

@youjung-hong
Copy link
Contributor

Hello.
First of all, thank you for your inquiry!

You said you wanted to increase the time between creation to one hour.
Does it mean the time interval shown in the weekly and daily view?
Or the drop down menu interval of creating the schedule modal?

I'll be waiting for the reply.
Thank you.

@youjung-hong youjung-hong added Enhancement Enhance performance or improve usability of original features. Question labels Aug 8, 2018
@guiwb
Copy link
Author

guiwb commented Aug 8, 2018

Hello, thank you very much for your interest in answering my question.

When I'm going to create a new event, I drag my mouse in the column, from the start time to the end, nowadays it lets me drag every 30 minutes, I wanted to make it by every hour.

If you also know how I can do the part of the period. Because that is more urgent.

@youjung-hong
Copy link
Contributor

youjung-hong commented Aug 9, 2018

I see :)
Please let me know if I'm wrong about what I understand or if you have any feedback on the following:

  • setting a start and end hour of weekly/daily view: (in consideration)
    • how to present the out-of-scope schedule
      • schedule 1 ~ 3, 21 ~ 23 => not showing? / schedule 7 ~ 10, 4 ~ 10 => showing?
  • setting a space of creation schedule guide(the blue layer): is it right?
    • if I keep dragging: 1 hour -> 2 hour -> 3hour / 1 hour -> 1.5hour -> 2hour

@guiwb
Copy link
Author

guiwb commented Aug 9, 2018

Hello, I'm going to the second part you understood, that's exactly it, the blue area walk hourly.

In the second part, if you look at the image below, it is what appears to me nowadays, and the part in red is what I want it to appear:

http://prntscr.com/kgmewa

Again, thanks for your attention and I await a return :)

@youjung-hong
Copy link
Contributor

So, you want an hour at first, because the time interval on the calendar is one hour.
I surely understand it.
Both two feature's are really nice!.
I'll look into it positively and let you know if it's done.

Thanks

@dongsik-yoo
Copy link
Contributor

PR is reviewed. Need some changes.

dongsik-yoo pushed a commit that referenced this issue Sep 5, 2018
feat: Week.options.hourStart, Week.options.hourEnd (resolves: #175)
@ntemirov
Copy link

Hellow.
Any news on this?
I have the same problem.
I would like to manage the minimal creation/updating interval of events.

@dongsik-yoo
Copy link
Contributor

Check #187 issue's last comment. Some nice guy give us fork version which implements what you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features. Question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants