feat: Week.options.hourStart, Week.options.hourEnd (resolves: #175) #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsik-yoo
reviewed
Sep 3, 2018
examples/js/default.js
Outdated
| @@ -42,7 +42,9 @@ | |||
| }], | |||
| week: { | |||
| showTimezoneCollapseButton: true, | |||
| timezonesCollapsed: false | |||
| timezonesCollapsed: false, | |||
| hourStart: 8, | |||
There was a problem hiding this comment.
Remove using this options in example code.
dongsik-yoo
reviewed
Sep 3, 2018
src/js/controller/viewMixin/week.js
Outdated
| * @returns {object} view model for time part. | ||
| */ | ||
| getViewModelForTimeView: function(start, end, time) { | ||
| getViewModelForTimeView: function(start, end, time, options) { |
There was a problem hiding this comment.
Make weekly options object separate with this module. This function doesn't need to know all options of weekly, just only to know hourStart, hourEnd.
dongsik-yoo
reviewed
Sep 3, 2018
src/js/view/template/week/time.hbs
Outdated
| {{#if model.isFocused}} | ||
| color: #ffffff; background-color:{{model.color}}; border-color:{{model.color}}; | ||
| {{else}} | ||
| color:{{model.color}}; background-color:{{model.bgColor}}; border-color:{{model.borderColor}}; | ||
| {{/if}} | ||
| {{model.customStyle}}" | ||
| >{{{time-tmpl model}}}</div> | ||
| {{#unless cropped}}<div class="{{CSS_PREFIX}}time-resize-handle handle-x" style="margin-left: {{@root.styles.paddingLeft}};"> </div>{{/unless}} | ||
| {{#unless isReadOnly}}<div class="{{CSS_PREFIX}}time-resize-handle handle-x" style="margin-left: {{@root.styles.paddingLeft}};"> </div>{{/unless}} |
There was a problem hiding this comment.
If the end time is over 24:00, the resize handle should be hidden.
dongsik-yoo
reviewed
Sep 3, 2018
src/js/view/week/time.js
Outdated
| * @returns {object} bound object for supplied view model. | ||
| */ | ||
| Time.prototype.getScheduleViewBound = function(viewModel, options) { | ||
| var X = this._getScheduleViewBoundX(viewModel, options); |
There was a problem hiding this comment.
This variable name should be lower case. Our eslint rule must be needed update.
dongsik-yoo
reviewed
Sep 3, 2018
src/js/view/week/time.js
Outdated
| Time.prototype.getScheduleViewBound = function(viewModel, options) { | ||
| var X = this._getScheduleViewBoundX(viewModel, options); | ||
| var Y = this._getScheduleViewBoundY(viewModel, options); | ||
| var isReadOnly = util.pick(viewModel, 'model', 'isReadOnly') || options.isReadOnly || false; |
There was a problem hiding this comment.
Is it necessary to check whether options.isReadOnly is undefined?
dongsik-yoo
suggested changes
Sep 3, 2018
|
All schedules should be shown in weekly if |
dongsik-yoo
force-pushed
the
feat/week-period
branch
from
232d7f6 to
59d3126
Compare
dongsik-yoo
approved these changes
Sep 5, 2018
dongsik-yoo
force-pushed
the
feat/week-period
branch
from
59d3126 to
a98b35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
fixes: #175
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨