Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow connecting social logins to existing users even if emails don't match #459

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Jan 12, 2024

When calling /oauth/:provider adds a new query arg connect which needs to contain a valid JWT. If the social login doesn't already exist, sign-ins successfully and the JWT belongs to a valid user, the social login is connected to the user even if the email addresses don't match.

Before submitting this PR:

Checklist

  • No breaking changes
  • Tests pass
  • New features have new tests
  • Documentation is updated

Breaking changes

Avoid breaking changes and regressions. If you feel it is unavoidable, make it explicit in your PR comment so we can review it and see how to handle it.

Tests

  • please make sure your changes pass the current tests (Use the make test or the make watch command).
  • if you are introducing a new feature, please write as much tests as possible.

Documentation

Please make sure the documentation is updated accordingly, in particular:

Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: ab841a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hasura-auth Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@onehassan onehassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbarrosop dbarrosop self-assigned this Jan 26, 2024
@dbarrosop dbarrosop merged commit b697197 into main Mar 18, 2024
11 checks passed
@dbarrosop dbarrosop deleted the socialconnect branch March 18, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants