Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update namespace #47

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update namespace #47

wants to merge 6 commits into from

Conversation

MarkMc1089
Copy link
Contributor

There were several problems, which this PR fixes.

  1. Some functions had duplicated names, e.g. both a DB and a df version but named identically.
  2. Some functions were not exported, e.g. @export specified in code but no entry in NAMESPACE. This prevented them being used.
  3. Some functions did not have man pages, or the man page was not up-to-date. Not critical, but running the documentation update to fix (2) fixed this as anyway.
  4. Package contained a .Rprofile, which was used in favour of my own (and others' own profile). Deleted, as it was preventing my personal R package folder being added to path.

Most functions have both a lazy table and dataframe version. It would make sense to have a single exported function for each use case, which then calls the appropriate version. This could be added very easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant