New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

26 add text review workflow #27

Merged

MarkMc1089 merged 34 commits into main from 26-add-text-review-workflow

Jan 15, 2024

Contributor

MarkMc1089 commented Oct 30, 2023

No description provided.

MarkMc1089 added 10 commits

October 27, 2023 11:15


          Add missing fields to LICENSE

fb342ef


          Add new markdown pages + modified namespaces in modules

6e70e8e


          Add markdown + JS for internal links

dbc50eb


          Add new module for additional markdown page

fab6847


          No intentional change, cannot see that anything has...

6888c21


          Bump version

d291e6a


          Remove div wrapper from nhs_card_tabstop; it was preventing the chart…

617545f

… from displaying


          Tidy up markdown examples + remove any not compatible syntax

f651b51


          Add further Suggests

390ea08


          Add review folder and code

83fd329

MarkMc1089 linked an issue

that may be closed by this pull request

Add text review workflow #26

Closed

MarkMc1089 commented

View reviewed changes

DESCRIPTION Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

R/app_server.R Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

R/mod_markdown_internal_link_example.R Outdated Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

R/utils_accessibility.R Outdated Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

inst/app/www/assets/markdown/mod_markdown_example.md Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

inst/app/www/js/custom.js Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

inst/app/www/js/custom.js Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

review/scripts/word_to_md.R Outdated Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

review/styles/draft-styles.rmd Outdated Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

review/tests/snapshot_tests.R Outdated Show resolved Hide resolved

MarkMc1089 added 2 commits

October 31, 2023 16:00


          Shorten long mod name + move comment on inline code out of code itself

2538cdf


          Add vignette + rewording + small changes + update DESCRIPTION

81e71e4

MarkMc1089 self-assigned this


          Build vignette + trying to fix GHA error

9a25dbb

MarkMc1089 marked this pull request as ready for review

November 1, 2023 09:04

MarkMc1089 requested a review from kygoffe

November 1, 2023 09:04


          Rename header args to heading in utils_accessibility + use tagQuery t…

0fd3bff

…o fix bug in nhs_card_tabstop

MarkMc1089 commented

View reviewed changes

R/mod_chart_example.R Outdated Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

R/utils_accessibility.R Show resolved Hide resolved

MarkMc1089 added 14 commits

November 17, 2023 13:45


          Merge branch 'main' into 26-add-text-review-workflow

65ea8a7


          Handle lints + attempt to get temp files from R CMD check GHA


          Merge branch '26-add-text-review-workflow' of https://github.com/nhsb…

6e73051

…sa-data-analytics/nhsbsaShinyR into 26-add-text-review-workflow


          Remove step from GHA, unnecessary

9b23ffb


          Use Windows for R CMD check GHA

2cb1fa1


          Include pandoc in R CMD check GHA

d26b647


          Temporarily save generated Word doc for troubleshooting GHA

da300a3


          Try using Word doc generated by GHA to compare against

c68d015


          Use better starting text for styles doc

2564a32


          Most functionality present and tested + vignette almost complete

bb61aca


          Amend test to account for differences between local and CI env

3e5c70e


          TEMP: print for verification of testthat:::on_ci

c251549


          Raise expected_differences for CI

36992b6


          Everything documented

729bd88

Contributor Author

MarkMc1089 commented Nov 22, 2023

@kygoffe - Finally ready for your review (in your own time, no rush). Please could you try it out locally, following the vignette? Let me know if anything is not working for you.

MarkMc1089 requested a review from kygoffe

November 22, 2023 16:33

kygoffe reviewed

View reviewed changes

tests/testthat/test-utils_review.R Outdated Show resolved Hide resolved

MarkMc1089 commented

View reviewed changes

tests/testthat/test-utils_review.R Show resolved Hide resolved

kygoffe reviewed

View reviewed changes

vignettes/writing-and-reviewing-text.Rmd Outdated Show resolved Hide resolved

kygoffe reviewed

View reviewed changes

R/test-helpers.R Outdated Show resolved Hide resolved

kygoffe reviewed

View reviewed changes

vignettes/writing-and-reviewing-text.Rmd Outdated Show resolved Hide resolved

kygoffe reviewed

View reviewed changes

Contributor

kygoffe left a comment •

edited

Loading

Little comments but happy to merge. thanks, this looks great!!!! 💯🥇

MarkMc1089 added 2 commits

January 15, 2024 15:09


          Updated following code review + update README

be5ff68


          Add section on installing from repo to README

2b96291

Contributor Author

MarkMc1089 commented Jan 15, 2024

Little comments but happy to merge. thanks, this looks great!!!! 💯🥇

Latest 2 commits were resolving the last few issues and I updated the README with the new functionality and files (that file tree is a pain!). Happy for me to merge, or want to have a double check first?

Contributor

kygoffe commented Jan 15, 2024

Little comments but happy to merge. thanks, this looks great!!!! 💯🥇

Latest 2 commits were resolving the last few issues and I updated the README with the new functionality and files (that file tree is a pain!). Happy for me to merge, or want to have a double check first?

happy for you to merge! thanks for this!

MarkMc1089 merged commit 7a40d6f into main

4 checks passed

MarkMc1089 deleted the 26-add-text-review-workflow branch

January 15, 2024 15:56

MarkMc1089 restored the 26-add-text-review-workflow branch

May 17, 2024 08:42

MarkMc1089 deleted the 26-add-text-review-workflow branch

May 17, 2024 08:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet