Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nhsuk-frontend version v9.2.0 #241

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Conversation

davidhunter08
Copy link
Collaborator

@davidhunter08 davidhunter08 commented Feb 10, 2025

Description

Bumped the version of the nhsuk-frontend to v9.2.0

Bump peer dependency nhsuk-frontend to v9.0.0

Page layout changes

  • added {% from 'attributes.njk' import nhsukAttributes %} to base page template (for component macros to work)
  • changed {% block breadcrumb %}{% endblock %} to {% block beforeContent %}{% endblock %}
  • moved {% block beforeContent %}{% endblock %} to within container before main
  • removed nhsuk-main-wrapper--s class because nhsuk-main-wrapper padding has decreased from 40px to 24px on mobile

Visual design changes

Card links font size on mobile changed from 18px to 19px

Before After
Screenshot 2025-02-10 at 15 28 54 Screenshot 2025-02-10 at 15 28 39

Section headings font size on mobile changed from 18px to 19px

Before After
Screenshot 2025-02-10 at 15 54 32 Screenshot 2025-02-10 at 15 53 57

Other stuff to consider

  • global header (web) - do we want to swap it for the new version? It changed in version 8 of the nhsuk-frontend but the app is using version 7

@davidhunter08 davidhunter08 linked an issue Feb 10, 2025 that may be closed by this pull request
4 tasks
@davidhunter08 davidhunter08 marked this pull request as ready for review February 12, 2025 14:55
Copy link
Collaborator

@edwardscull edwardscull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks good. We will need to do v3.0.0 bump.

package.json Outdated Show resolved Hide resolved
@davidhunter08 davidhunter08 changed the title Bump nhsuk-frontend version v9.1.0 Bump nhsuk-frontend version v9.2.0 Feb 14, 2025
Copy link
Collaborator

@edwardscull edwardscull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@davidhunter08 davidhunter08 merged commit 5d7a2b2 into main Feb 14, 2025
4 checks passed
@davidhunter08 davidhunter08 deleted the bump-nhsuk-frontend-9.1.0 branch February 14, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump NHS.UK frontend version (v9.2.0)
2 participants