Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template to main app folder #395

Closed
wants to merge 1 commit into from

Conversation

frankieroberto
Copy link
Contributor

This is another step towards being able to remove the docs/ folder.

The template.html file is currently inherited by all pages within the main app/ folder, but confusingly is located within docs/.

This is another step towards being able to remove the `docs/` folder.

The `template.html` file is currently inherited by all pages within the main `app/` folder, but confusingly is located within `docs/`.
@frankieroberto frankieroberto mentioned this pull request Nov 11, 2024
5 tasks
Copy link
Contributor

@anandamaryon1 anandamaryon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankieroberto Makes sense.

Out of interest, the template seems to import all (or most of) the components. Assume this is just so that users don't have to add the import in themselves each time they add a component to their page? If so, I think we need to add the new task list (and make a note to always add to this list when new components are released)

@frankieroberto
Copy link
Contributor Author

Hmm having chatted to @edwardhorsford we think it’s best to leave this in docs/ for now, to make future updates to it easier.

Possibly it could move to lib/ rather than docs/.

Longer-term it would be better to have the page template be part of nhuk-frontend instead, and then import the template from there (this is what govuk-frontend does). I’ll create a separate issue in the backlog for that.

@frankieroberto
Copy link
Contributor Author

Follow-up issue on NHS Frontend: nhsuk/nhsuk-frontend#1072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants