[minor] refactor: Update to use service class name as client library name when client name input is empty
#637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After: |
varshini-senthil
changed the title
service class name as client library name when client name input is emptyservice class name as client library name when client name input is empty
varshini-senthil
requested review from
dixonjoel,
aepete,
jasonmreding and
DavidCurtiss
as code owners
jasonmreding
approved these changes
Feb 21, 2025
varshini-senthil
deleted the
users/varshini/update-client-name-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Generate Client.vito use theservice classname of the measurement plug-in as the client library name, instead of using the display name, when theclient nameinput provided to the wrapper VI is an empty string.Why should this Pull Request be merged?
Generate Client.vito use theservice classname as the client library name when theclient nameinput provided to the wrapper VI is an empty string. This change ensures the default value used for theclient nameis unique, avoiding potential naming conflicts due to similar library names as in the case of using the measurement's display name.What testing has been done?
client nameinput set to empty string and verified the wrapper VI is working as expected.