-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced internal encoders with message encoder calling public API #767
Conversation
Test Results 30 files ± 0 30 suites ±0 43m 7s ⏱️ - 2m 55s Results for commit e76e00a. ± Comparison against base commit ac37644. This pull request removes 41 and adds 20 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/serialization_strategy.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/message_serializer.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/serializer.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/message_serializer.py
Outdated
Show resolved
Hide resolved
Please update the PR description. Edit: oh, I see, you did, but you kept the TODOs. Delete the TODOs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not done reviewing this. FYI, my team is doing release finalization now, so I might not get back to this for a few days.
ni_measurement_plugin_sdk_service/_internal/parameter/decoder_strategy.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/encoder.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/encoder.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/encoder.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/_decoder_types.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Show resolved
Hide resolved
@LazeringDeath generally looks good. I'll take a more thorough look when all the checks are passing. |
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/grpc_servicer.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/encoder.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/encoder.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/default_value.py
Outdated
Show resolved
Hide resolved
ni_measurement_plugin_sdk_service/_internal/parameter/encoder.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're on the home stretch.
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/_get_type.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/_get_type.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully this is the last round.
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/decoder.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/metadata.py
Outdated
Show resolved
Hide resolved
...s/service/ni_measurement_plugin_sdk_service/_internal/parameter/serialization_descriptors.py
Outdated
Show resolved
Hide resolved
…helper functions for enums
What does this Pull Request accomplish?
Replaced the Google's internal encoders with message encoders without affecting performance or results.
Why should this Pull Request be merged?
Resolve issue#35 and make the serializer more robust/less complicated.
What testing has been done?
Passed all measurementlink tests and PR checks.