Skip to content

Commit

Permalink
New icons for AI chat, alarms, and like/dislike; update icon rectangl…
Browse files Browse the repository at this point in the history
…e-lines. (#2532)

# Pull Request

## 🤨 Rationale

#2530

## 👩‍💻 Implementation

Followed the normal process. Some notes:
1. I renamed the "alarm" icon names suggested in the issue to use "bell"
which aligns better with existing icons and our naming guidance.
2. I removed the color from the bell-radial-lines icon as is our normal
practice

## 🧪 Testing

Verify you can apply severity on the new icons.

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Fred Visser <[email protected]>
  • Loading branch information
jattasNI and fredvisser authored Feb 7, 2025
1 parent 4ff4916 commit 6fc86f5
Show file tree
Hide file tree
Showing 9 changed files with 55 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "New icons for AI chat, alarms, and like/dislike. Updated icon rectangle-lines.",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "minor"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "New icons for AI chat, alarms, and like/dislike. Updated icon rectangle-lines.",
"packageName": "@ni/nimble-tokens",
"email": "[email protected]",
"dependentChangeType": "minor"
}
15 changes: 15 additions & 0 deletions packages/nimble-components/src/icon-base/tests/icon-metadata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ export const iconMetadata: {
IconAdd: {
tags: ['add input field']
},
IconMessageBot: {
tags: ['assistance', 'information', 'help']
},
IconArrowDown: {
tags: ['sort', 'arrow', 'down', 'descending']
},
Expand Down Expand Up @@ -103,9 +106,15 @@ export const iconMetadata: {
IconBellAndComment: {
tags: ['alarm', 'notification']
},
IconBellCheck: {
tags: ['acknowledged', 'alarm']
},
IconBellCircle: {
tags: ['alarm']
},
IconBellOn: {
tags: ['set', 'urgent', 'notification', 'alarm']
},
IconBellSolidCircle: {
tags: ['alarm']
},
Expand Down Expand Up @@ -559,9 +568,15 @@ export const iconMetadata: {
IconThreeVerticalLines: {
tags: []
},
IconThumbDown: {
tags: ['dislike', 'disapprove', 'not good', 'no']
},
IconThumbtack: {
tags: []
},
IconThumbUp: {
tags: ['like', 'approve', 'good', 'yes']
},
IconTileSize: {
tags: []
},
Expand Down
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/bell-check_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/bell-on_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/message-bot_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/thumb-down_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/nimble-tokens/dist/icons/svg/thumb-up_16x16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 6fc86f5

Please sign in to comment.