Skip to content

Commit

Permalink
Update to Angular 18 (#2508)
Browse files Browse the repository at this point in the history
# Pull Request

## 🀨 Rationale

Part of Angular 18 migration ([AzDO work
item](https://dev.azure.com/ni/DevCentral/_workitems/edit/2973920))

## πŸ‘©β€πŸ’» Implementation

- bumped Angular dependency versions from 17 to 18
- updated Angular projects to use new, Angular-18-compatible
`ni-eslint-config-angular` version
- updated forked Angular files in
`angular-workspace/nimble-angular/src/thirdparty`
- No meaningful changes were made. In some cases I left the original
imports but commented them out, rather than removing them like we had
done before.
- auto-fix some new, minor lint violations:
   - unnecessary uses of non-null assertion (`!`)
   - unnecessary uses of `as const` on string literals
- one prefer-optional-chaining fix (e.g. `!x.foo?.bar()` instead of
`!x.foo || !x.foo.bar()`)
   - one forbidden use of `Readonly<Foo[]>` (change to `readonly Foo[]`)

## πŸ§ͺ Testing

Builds and automated tests pass

## βœ… Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: rajsite <[email protected]>
  • Loading branch information
m-akinc and rajsite authored Feb 11, 2025
1 parent 1f99c0b commit ed385c6
Show file tree
Hide file tree
Showing 32 changed files with 5,843 additions and 4,615 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "major",
"comment": "Update to Angular 18",
"packageName": "@ni/nimble-angular",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Minor lint fixes",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "major",
"comment": "Update to Angular 18",
"packageName": "@ni/spright-angular",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Loading

0 comments on commit ed385c6

Please sign in to comment.