Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nimble-base prefix to tokens #259

Merged
merged 4 commits into from
Jan 13, 2022
Merged

Add nimble-base prefix to tokens #259

merged 4 commits into from
Jan 13, 2022

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Jan 13, 2022

Pull Request

🀨 Rationale

This PR addresses the second half of #236 (comment) by adding the prefix nimble-base to the raw tokens defined in ni/tokens.

πŸ‘©β€πŸ’» Implementation

  • Modified the nimble-extensions for the Adobe DSP to add a prefix to the names. Used a workaround as I couldn't see a way to configure a prefix using the DSP itself. I created the following issue for the workaround: Define a prefix for css and scss filesΒ AdobeXD/design-system-package-dsp#27
  • Only defined the prefix for css and scss files. The rationale being that those are set globally in a page and can conflict. The JS files are modules that are explicitly imported and not globally available so are unlikely to get used accidentally.

πŸ§ͺ Testing

Just CI builds, no explicit testing.

βœ… Checklist

Copy link
Contributor

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under the assumption that this will go in imminently, I updated #231 to use the new naming scheme in the nimble-tokens README.md. Feel free to leave a comment on that PR if you think we should go into more detail about the naming scheme.

Co-authored-by: Jesse Attas <[email protected]>
Copy link
Contributor

@fredvisser fredvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Cool that you were able to find a fairly clean way to extend the existing kebab transform - πŸ‘

@rajsite rajsite merged commit adb7088 into main Jan 13, 2022
@rajsite rajsite deleted the css-prefix branch January 13, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants