New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Add Subaddress.vi #116

Draft

KishorBasavaraju-NI wants to merge 13 commits into main from users/kbasavar/comm-issue

KishorBasavaraju-NI commented Nov 11, 2024

This contribution adheres to CONTRIBUTING.md.

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.

What does this Pull Request accomplish?

TODO: Include high-level description of the changes in this pull request.

Why should this Pull Request be merged?

TODO: Justify why this contribution should be part of the project.

What testing has been done?

TODO: Detail what testing has been done to ensure this submission meets requirements.


          Update Add Subaddress.vi

ce6077b

Collaborator

niveristand-diff-bot commented Nov 11, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png


          Adding subaddress under direction

34fa185

Collaborator

niveristand-diff-bot commented Nov 12, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png


          Corrected the GUID for Direction

fbd4994

Collaborator

niveristand-diff-bot commented Nov 14, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

Kishor Basavaraju added 2 commits

November 18, 2024 23:08


          Added a option to enable new feature with checkbox

46058cc


          Update GlobalVariables.vi

20df019

Collaborator

niveristand-diff-bot commented Nov 18, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Parameters Configuration File.vi.png

GlobalVariables.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

The following VIs could not be diffed:

C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\Scripting\Configuration Files\Get Property - Include Direction Section.vi
C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\Scripting\Configuration Files\Set Property - Include Direction Section.vi
C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Configuration Files.vi
C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Direction.vi

Collaborator

niveristand-diff-bot commented Nov 18, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Parameters Configuration File.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

The following VIs could not be diffed:

C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\Scripting\Configuration Files\Get Property - Include Direction Section.vi
C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\Scripting\Configuration Files\Set Property - Include Direction Section.vi
C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Configuration Files.vi
C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Direction.vi


          corrected the property name

e9dd9d4

Collaborator

niveristand-diff-bot commented Nov 19, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Get Property - Include Direction Section.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Parameters Configuration File.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

The following VIs could not be diffed:

C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\Scripting\Configuration Files\Set Property - Include Direction Section.vi
C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Configuration Files.vi
C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Direction.vi


          Opening and saving the vi again to solve build issue

c2e4f5f

Collaborator

niveristand-diff-bot commented Nov 19, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Get Property - Include Direction Section.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Parameters Configuration File.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Property - Include Direction Section.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

The following VIs could not be diffed:

C:\agent_work\4\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Configuration Files.vi
C:\agent_work\4\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Direction.vi


          reverting changes

9d728c0

Collaborator

niveristand-diff-bot commented Nov 19, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Get Property - Include Direction Section.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Property - Include Direction Section.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Configuration Files.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

The following VIs could not be diffed:

C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Direction.vi


          Update Constants.vi

Collaborator

niveristand-diff-bot commented Nov 19, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Get Property - Include Direction Section.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Property - Include Direction Section.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Configuration Files.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

The following VIs could not be diffed:

C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Direction.vi


          Modified the constant value

0899a91

Collaborator

niveristand-diff-bot commented Nov 19, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Get Property - Include Direction Section.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Property - Include Direction Section.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Configuration Files.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

The following VIs could not be diffed:

C:\agent_work\2\s\niveristand-aim-milStd1553-custom-device\Source\Custom Device Support\System Explorer\Implementation\System Explorer\Pages\Direction.vi

Kishor Basavaraju added 2 commits

November 19, 2024 17:08


          Added new vi to page map

9253deb


          Updated constants again by making current value as default

a473b06

Collaborator

niveristand-diff-bot commented Nov 19, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Get Property - Include Direction Section.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Property - Include Direction Section.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Configuration Files.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Direction.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Build Map from Page GUIDs to Page VIs.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

Collaborator

niveristand-diff-bot commented Nov 19, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Get Property - Include Direction Section.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Property - Include Direction Section.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Configuration Files.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Direction.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Build Map from Page GUIDs to Page VIs.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png


          Corrected glyph path + updated help + modified Configuration Files.vi

1704e40

Collaborator

niveristand-diff-bot commented Nov 19, 2024

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress to Remote Terminal.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Add Subaddress.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Get Property - Include Direction Section.vi.png

AIM MIL-STD-1553 Scripting.lvlib--GlobalVariables.vi.png

AIM MIL-STD-1553 Scripting.lvlib--Set Property - Include Direction Section.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Configuration Files.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Direction.vi.png

AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Build Map from Page GUIDs to Page VIs.vi.png

Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

skolthay Awaiting requested review from skolthay skolthay will be requested when the pull request is marked ready for review skolthay is a code owner

gahegde-ni Awaiting requested review from gahegde-ni gahegde-ni will be requested when the pull request is marked ready for review gahegde-ni is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet