-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scripting examples for import parameters configuration file and for build from cluster configuration #105
Conversation
a6d5865
to
c510b2a
Compare
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Ballard ARINC 429 Scripting Examples.lvlib--Import Parameters Configuration to New Ballard ARINC 429 Custom Device.vi.png |
Note to reviewers, here's what's ready for feedback:
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Ballard ARINC 429 Scripting Examples.lvlib--Import Parameters Configuration to New Ballard ARINC 429 Custom Device.vi.png |
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Ballard ARINC 429 Scripting Examples.lvlib--Import Parameters Configuration to New Ballard ARINC 429 Custom Device.vi.png |
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Ballard ARINC 429 Scripting Examples.lvlib--Import Parameters Configuration to New Ballard ARINC 429 Custom Device.vi.png |
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Ballard ARINC 429 Scripting Examples.lvlib--Import Parameters Configuration to New Ballard ARINC 429 Custom Device.vi.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Convert to Absolute Path.vi
used in the two top-level example VIs is linked toSLSC Switch Examples.lvlib
.
The file paths of the VIs in vi.lib
don't look like final paths we would want, so we'll probably need to revisit the top-level files to relink them once we decide on final paths, but hopefully that won't be too bad.
|
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. Ballard ARINC 429 Scripting Examples.lvlib--Import Parameters Configuration to New Ballard ARINC 429 Custom Device.vi.png |
Installation directory structure reflects built structure. It is pretty easy to change the example project dependencies if we later decide to change the structure. I would like to build the palette soon, and that is very coupled to the installation file structure but can be changed easily enough using the palette API. Do you have a vision for what you want the structure to look like on disk? |
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. |
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. |
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. |
I don't see the point of duplicating the code for the tests. If we're going to have a test for the example code, we should just call the example VIs to generate the system definitions and then deploy those. |
I would imagine the ARINC 429 library, Import library, and Shared being located at This also makes it much easier to create the two separate |
…d ARINC 429 instance of custom device generated from the comms bus template
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. |
Agree with vision and proposal, and as discussed offline, we will defer these moves for now. Filed #109 |
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Post-Build Action.vi
doesn't run after the Examples build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several VIs from the Shared
directory are missing from the scripting API when run through the installer. I don't think that affects this PR, but it is something that needs to be fixed or else you can't run the examples.
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. |
Bleep bloop! LabVIEW Diff Robot here with some diffs served up hot for your pull request. Notice something funny? Help fix me on my GitHub repo. |
What does this Pull Request accomplish?
Implements and documents two examples to demonstrate use of the scripting API.
Why should this Pull Request be merged?
Examples will help custom device developers and users learn and use the custom device.
What testing has been done?
Ran each example and deployed the resulting system definition (after configuring target).