Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the port to the hostname #11

Merged
merged 1 commit into from Apr 21, 2020
Merged

Adding the port to the hostname #11

merged 1 commit into from Apr 21, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2019

solves #10

@nicholasamorim
Copy link
Owner

Not so sure about this change. It used to be like that but if I remember correctly several other places needed the hostname alone. I will take a deeper look at what caused my problem and see if this is suitable indeed or not.

@ghost
Copy link
Author

ghost commented Apr 24, 2019

Alright, let me know when you take time to check that :).
Here everything seems to work but I haven't tried notary for example.
Without that, http redirect doesn't work and docker push either

@nicholasamorim
Copy link
Owner

Yes! I'm looking into Molecule this week to add tests for this role so that we can track these issues and effects better.

@ghost
Copy link
Author

ghost commented May 10, 2019

@nicholasamorim
Hi! :)
Any news on molecule? I haven't used it myself but if you need some help, I should have a bit more free time next month

@nicholasamorim
Copy link
Owner

nicholasamorim commented May 20, 2019

Hey, @achrjulien, I haven't had time yet. I did check Molecule out but haven't had time to implement it for this role.

The main reason being that I moved away from Harbor to Quay.io.

If you can open a PR with tests, all the better. If not, I reckon it will take some time from my side.

@ghost
Copy link
Author

ghost commented May 22, 2019

Was there any test in particular you were thinking about? My time is quite limited as well lately :)

@nicholasamorim
Copy link
Owner

@achrjulien I suppose verify the installation is correct, all components are running on docker and ultimately check if users/projects were created.

@ghost
Copy link
Author

ghost commented May 27, 2019

Thanks! @nicholasamorim
Got more work on the table for next month so I won't be able to help before July. If someone reads here and want to help, please do so :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant