Skip to content

Commit

Permalink
Fix position validation warnings (#40)
Browse files Browse the repository at this point in the history
* Fix position validation warnings

* Bump version, fix GH action
  • Loading branch information
nicholasbair authored Jan 4, 2025
1 parent b0d855d commit cdebc92
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/elixir.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ jobs:
strategy:
matrix:
elixir: ['1.14', '1.15', '1.16', '1.17']
otp: ['24.0', '25.0', '26.0', '27.0']
otp: ['24.3.4.13', '25.3.2.8', '26.2.1', '27.0.0']
exclude:
- elixir: '1.14'
otp: '26.0'
otp: '26.2.1'
- elixir: '1.14'
otp: '27.0'
otp: '27.0.0'
- elixir: '1.15'
otp: '27.0'
otp: '27.0.0'
- elixir: '1.16'
otp: '27.0'
otp: '27.0.0'
- elixir: '1.17'
otp: '24.0'
otp: '24.3.4.13'

steps:
- uses: actions/checkout@v3
Expand All @@ -38,7 +38,6 @@ jobs:
with:
elixir-version: ${{ matrix.elixir }}
otp-version: ${{ matrix.otp }}
http-client-timeout: 300
- name: Restore dependencies cache
uses: actions/cache@v3
with:
Expand Down
4 changes: 2 additions & 2 deletions lib/models/definitions/position/position_side.ex
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ defmodule ExOanda.PositionSide do
:financing, :commission, :dividend_adjustment, :guaranteed_execution_fees
])
|> validate_required([
:units, :average_price, :trade_ids, :pl, :unrealized_pl, :resettable_pl,
:financing, :commission, :dividend_adjustment, :guaranteed_execution_fees
:units, :trade_ids, :pl, :unrealized_pl, :resettable_pl,
:financing, :dividend_adjustment, :guaranteed_execution_fees
])
end
end
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule ExOanda.MixProject do
def project do
[
app: :ex_oanda,
version: "0.0.3",
version: "0.0.4",
elixir: "~> 1.14",
start_permanent: Mix.env() == :prod,
deps: deps(),
Expand Down

0 comments on commit cdebc92

Please sign in to comment.