Small improvements to error formatting #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedbrandston
approved these changes
Feb 6, 2025
Add the word "filesystem". "corrupt filesystem"/"incompatible filesystem" makes errors a little clearer if printed in isolation.
Since the `Corrupt` type is just a thin wrapper used to make the inner enum opaque, make it invisible in the `Debug` format.
nicholasbishop
force-pushed
the
bishop-improve-corrupt-fmt
branch
from
b749b82 to
2a1d060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrupt/Incompatibleerrors, change theDisplayimpl to say "corrupt filesystem"/"incompatible filesystem" so the error is clearer when printed in isolationDebugimpl forCorruptpass through to the innerCorruptKind. This shortens the output from, e.g.,Corrupt(Corrupt(BlockRead { .. }))toCorrupt(BlockRead { .. }).