Replace Incompatible::DirectoryEncrypted with Ext4Error::Encrypted
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedbrandston
approved these changes
Feb 10, 2025
This will replace Incompatible::DirectoryEncrypted in later commits. There are two reasons for moving this from `Incompatible` to a top-level error: 1. The other errors in `Incompatible` prevent the filesystem from being loaded. However, the lack of support for encrypted directories just prevents those specific paths from being loaded. So any other `Incompatible` error is essentially fatal, but `Incompatible::DirectoryEncrypted` can be handled. 2. If, in the future, support for reading encrypted directories is added, we'll still need an error in case the right encryption key isn't loaded. The new error is named `Encrypted` instead of `DirectoryEncrypted` because although ext4 encryption is directory based, files within a directory can of course be encrypted too, so a more general name is appropriate.
nicholasbishop
force-pushed
the
bishop-move-encrypted-err
branch
from
180423c to
0a2382d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for moving this from
Incompatibleto a top-level error:Incompatibleprevent the filesystem from being loaded. However, the lack of support for encrypted directories just prevents those specific paths from being loaded. So any otherIncompatibleerror is essentially fatal, butIncompatible::DirectoryEncryptedcan be handled.The new error is named
Encryptedinstead ofDirectoryEncryptedbecause although ext4 encryption is directory based, files within a directory can of course be encrypted too, so a more general name is appropriate.#389