Demo/save snapshot on quit #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed via email, if you use version “18.87.57.28” or “19.89.57.6”, and apply a backgroundColor, it works ok Varun.
-Which Supports "backgroundColor" fix
…l/platform-api-project-seed into demo/save-snapshot-on-quit
Added close-requested listener
…l/platform-api-project-seed into demo/save-snapshot-on-quit
- Added a default title to stop the URL showing when a tab view is created. - Added an artificially slow server to highlight how the view looks when waiting for the html and js to download.
Removed state - maximized for issue replication...
Hey Varun, Thanks for updating the repository so we were able to reproduce the issue. We can see that you were only saving the "windows" part of the snapshot, there's also "monitor" data which was not being saved. Since we didn't have the monitor information, the layout engine was unable to determine where to display the windows. We have changed the code to save the entire snapshot and this has fixed the issue. Please let us know how you get on and thanks for your patience while we got to the bottom of the issue. Phil.
Hey Varun, this will fix it. I compared Imran's local changes to mine and discovered that it was a combination of 2 things, the css change and including the default URL for the defaultWindowOptions. Both combined fix the issue.
Hey Varun, Hopefully this addresses the issue you raised here -> #6. Please let me know how you get on with this approach. Thanks, Phil.
Hey Varun, Please have a look at the fix for this issue. You need to unfocus the window before hiding it. Thanks, Phil.
…e sanpshot is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Varun,
Please have a look at a couple of small changes to our repo. 1 to add a default title to each view, to stop it showing the URL and another to try and recreate the issue of the window showing a rectangle (with background color set) while it waits for the html/js to download.
Any questions, please just let me know.
Phil.