Proposed fix for escapeTagRegExp does not escape all possible problematic characters #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…overflow.com/a/6969486) -- Question marks in attribute values were causing failure to parse the shortcodes, e.g. [mytag myattribute="What?"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I ran into an issue where question marks in attribute values were causing a failure to parse shortcodes that contained them, e.g.
[mytag myattribute="What?"]
I traced this down to escapeTagRegExp failing to escape the question marks, so I added additional regex string escape characters as per https://stackoverflow.com/a/6969486.
Hope this helps, and thanks for shortcode.js !