Skip to content

Commit

Permalink
Merge pull-request kanboard#763
Browse files Browse the repository at this point in the history
  • Loading branch information
fguillot committed Apr 3, 2015
2 parents 68df40b + 248c160 commit 5631210
Show file tree
Hide file tree
Showing 4 changed files with 126 additions and 0 deletions.
83 changes: 83 additions & 0 deletions app/Action/TaskAssignColor.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
<?php

namespace Action;

use Model\Task;

/**
* Assign a color to a task
*
* @package action
*/
class TaskAssignColor extends Base
{
/**
* Get the list of compatible events
*
* @access public
* @return array
*/
public function getCompatibleEvents()
{
return array(
Task::EVENT_MOVE_COLUMN,
);
}

/**
* Get the required parameter for the action (defined by the user)
*
* @access public
* @return array
*/
public function getActionRequiredParameters()
{
return array(
'column_id' => t('Column'),
'color_id' => t('Color'),
);
}

/**
* Get the required parameter for the event
*
* @access public
* @return string[]
*/
public function getEventRequiredParameters()
{
return array(
'task_id',
'column_id',
);
}

/**
* Execute the action (set the task color)
*
* @access public
* @param array $data Event data dictionary
* @return bool True if the action was executed or false when not executed
*/
public function doAction(array $data)
{
$values = array(
'id' => $data['task_id'],
'color_id' => $this->getParam('color_id'),
);

return $this->taskModification->update($values);
}

/**
* Check if the event data meet the action condition
*
* @access public
* @param array $data Event data dictionary
* @return bool
*/
public function hasRequiredCondition(array $data)
{
return $data['column_id'] == $this->getParam('column_id');
}
}
1 change: 1 addition & 0 deletions app/Model/Action.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public function getAvailableActions()
$values = array(
'TaskClose' => t('Close a task'),
'TaskOpen' => t('Open a task'),
'TaskAssignColor' => t('Assign a color to a task'),
'TaskAssignSpecificUser' => t('Assign the task to a specific user'),
'TaskAssignCurrentUser' => t('Assign the task to the person who does the action'),
'TaskDuplicateAnotherProject' => t('Duplicate the task to another project'),
Expand Down
1 change: 1 addition & 0 deletions docs/api-json-rpc.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -1390,6 +1390,7 @@ Response example:
"id": 1433237746,
"result": {
"TaskLogMoveAnotherColumn" : "Add a comment logging moving the task between columns",
"TaskAssignColor" : "Assign a color to a task",
"TaskAssignColorUser" : "Assign a color to a specific user",
"TaskAssignCategoryColor" : "Assign automatically a category based on a color",
"TaskAssignColorCategory" : "Assign automatically a color based on a category",
Expand Down
41 changes: 41 additions & 0 deletions tests/units/ActionTaskAssignColorTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
<?php

require_once __DIR__.'/Base.php';

use Event\GenericEvent;
use Model\Task;
use Model\TaskCreation;
use Model\TaskFinder;
use Model\Project;

class ActionTaskAssignColorTest extends Base
{
public function testColorChange()
{
$action = new Action\TaskAssignColor($this->container, 1, Task::EVENT_MOVE_COLUMN);
$action->setParam('column_id', 2);
$action->setParam('color_id', 'green');

// We create a task in the first column
$tc = new TaskCreation($this->container);
$tf = new TaskFinder($this->container);
$p = new Project($this->container);

$this->assertEquals(1, $p->create(array('name' => 'test')));
$this->assertEquals(1, $tc->create(array('title' => 'test', 'project_id' => 1, 'column_id' => 1, 'color_id' => 'yellow')));

$event = array(
'project_id' => 1,
'task_id' => 1,
'column_id' => 2,
'color_id' => 'green',
);

// Our event should be executed
$this->assertTrue($action->execute(new GenericEvent($event)));

// Our task should have color green
$task = $tf->getById(1);
$this->assertEquals('green', $task['color_id']);
}
}

0 comments on commit 5631210

Please sign in to comment.