Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ember 4 #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

luxzeitlos
Copy link

This is a try to fix compatibility with ember 4. Especially this removes @ember/legacy-built-in-components.
For this I basically completely changed the special <LinkTo component to not extend the built-in component but instead proxy it.

@nickschot
Copy link
Owner

nickschot commented Apr 3, 2022

This addon (legacy-built-in-components) should be compatible with ember 4 (and appears to be from current state of master). We will need to implement some kind of replacement, but I'm not sure yet if I want it to be:

  • this
  • a modifier the user can apply
  • simply the current close action and we update the docs that the user can use the {{on "click"}} modifier to call the close action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants