Fix fastboot compatibility and add smoke test #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the body-scroll-lock library that we use only checks
typeof window === 'undefined'before trying to add event listeners. In Fastboot this is not the case, yetaddEventListeneris not available.Apart from adding a smoke test for fastboot support, this fixes fastboot compatibility by dynamically importing
body-scroll-lockin non-fastboot environments.Soon we will be able to migrate to https://developer.mozilla.org/en-US/docs/Web/CSS/overscroll-behavior once Safari 16 gets released/adopted and get rid of the library altogether.