Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build system now supports more build environments #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BasisDeveloper
Copy link

Before if you were compiling with Clang on Windows using MSYS2 or any environment that wasn't Windows native it would try and use MSVC build flags no matter what compiler was selected. I fixed that issue with my edits. Change anything you dislike.
(By the way, I've never contributed to someone else's project, if I'm suppose to open an issue first no matter what, I'm genuinely sorry)

Before if you were compiling with Clang on Windows using MSYS2 or any environment that wasn't Windows native it would try and use MSVC build flags no matter what compiler was selected. Now that isn't a problem.
(I changed the styling of the CMake file to add more whitespace, sorry if that annoys anyone, you can edit it to your liking.)
@nico nico force-pushed the main branch 2 times, most recently from 5a6b7cf to 77f83c7 Compare August 4, 2024 17:08
@maleadt
Copy link

maleadt commented Sep 25, 2024

Can confirm that this is needed to fix:

[12:08:15] i686-w64-mingw32-g++: error: /Zc:inline: No such file or directory
[12:08:15] i686-w64-mingw32-g++: error: /EHs-c-: No such file or directory
[12:08:15] i686-w64-mingw32-g++: error: /GR-: No such file or directory
[12:08:15] i686-w64-mingw32-g++: error: /wd4244: No such file or directory
[12:08:15] i686-w64-mingw32-g++: error: /wd4267: No such file or directory
[12:08:15] make[2]: *** [CMakeFiles/demumble.dir/build.make:77: CMakeFiles/demumble.dir/demumble.cc.obj] Error 1
[12:08:15] make[2]: *** Waiting for unfinished jobs....

@nico Could this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants