-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fallback docs for crates #152
Conversation
Autoformatting is nice, but please put it in a separate commit? (Or PR if your prefer.) |
there's some clippy stuff so ill make a followup PR for all that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that auto-formatting should be a separate PR.
221b888
to
46c2580
Compare
some crates have multiple sets of docs, the ones in bold are the ones i linked:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for digging this up, seems like a nice improvement!
6590b36
to
5a700f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these crates that have links because they weren't published to crates.io yet now are published (xilem, parley, vizia). But this seems like a solid improvement anyway. We might want to look at a way to link to both guide and reference docs at some point. Although I'm wary of providing too many options.
basically #151 (comment)
currently, if a crate has a
docs
value but nolink
, the customdocs
are favoured overdocs.rs/name
my editor auto-formatted, lemme know if you want me to turn that off