Better message on dbpedia connection failure

nigelhorne · Dec 29, 2023 · 0defab7 · 0defab7
1 parent 48814e8
commit 0defab7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/gedcom b/gedcom
@@ -12439,8 +12439,9 @@ sub dbpedia
 		$surname = 'NULL';
 	}
 
-	print "https://lookup.dbpedia.org/api/search?query=$firstname%20$surname\n" if($opts{'v'});
-	if(($firstname ne '?') && (my $resp = $cached_browser->get("https://lookup.dbpedia.org/api/search?query=$firstname%20$surname"))) {
+	my $url = "https://lookup.dbpedia.org/api/search?query=$firstname%20$surname";
+	print "$url\n" if($opts{'v'});
+	if(($firstname ne '?') && (my $resp = $cached_browser->get($url))) {
 		if($resp->is_success()) {
 			if(my $arrayofresults = XML::Hash->new()->fromXMLStringtoHash($resp->decoded_content())->{'ArrayOfResults'}) {
 				RESULT: foreach my $result(@{$arrayofresults->{'Result'}}) {
@@ -12606,7 +12607,7 @@ sub dbpedia
 				}
 			}
 		} else {
-			complain({ person => $person, warning => "dbpedia: $firstname $surname failed: " . $resp->status_line() });
+			complain({ person => $person, warning => "$url: $firstname $surname failed: " . $resp->status_line() });
 		}
 	}
 }