Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: SP refactor #3733

Open
wants to merge 48 commits into
base: dev
Choose a base branch
from
Open

WIP: SP refactor #3733

wants to merge 48 commits into from

Conversation

MilosKozak
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 31.62939% with 856 lines in your changes missing coverage. Please review.

Project coverage is 26.81%. Comparing base (52b3048) to head (9f6f9af).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...p/aaps/plugins/sync/nsclient/DataSyncSelectorV1.kt 0.00% 85 Missing ⚠️
...aaps/plugins/sync/nsclientV3/DataSyncSelectorV3.kt 0.00% 85 Missing ⚠️
app/src/main/kotlin/app/aaps/MainApp.kt 0.00% 82 Missing ⚠️
...ps/plugins/sync/xdrip/DataSyncSelectorXdripImpl.kt 0.00% 73 Missing ⚠️
...mplementation/sharedPreferences/PreferencesImpl.kt 40.57% 37 Missing and 4 partials ⚠️
...ins/sync/wear/wearintegration/DataHandlerMobile.kt 0.00% 38 Missing ⚠️
...p/aaps/plugins/sync/nsclientV3/NSClientV3Plugin.kt 21.95% 32 Missing ⚠️
...tlin/info/nightscout/pump/combov2/ComboV2Plugin.kt 10.00% 27 Missing ⚠️
.../kotlin/app/aaps/plugins/sync/xdrip/XdripPlugin.kt 18.18% 18 Missing ⚠️
...kotlin/app/aaps/activities/MyPreferenceFragment.kt 0.00% 15 Missing ⚠️
... and 90 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #3733      +/-   ##
============================================
- Coverage     26.86%   26.81%   -0.06%     
- Complexity     6087     6208     +121     
============================================
  Files          2267     2340      +73     
  Lines        119199   121360    +2161     
  Branches      15365    15547     +182     
============================================
+ Hits          32027    32543     +516     
- Misses        84687    86330    +1643     
- Partials       2485     2487       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.3% Duplication on New Code (required ≤ 4%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant