Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsulinPlugin and Insulin management within profile pre-requisite #3799

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Philoul
Copy link
Contributor

@Philoul Philoul commented Jan 31, 2025

This first PR is to add some methods/extensions to ICfg:

  • better management of conversion between long values (ms) saved in database and Int/double values usally used for peak (min) and dia (h)
  • json import/export

include ICfg management within PureProfile

  • 1rst open topic, in this proposal, pureProfileFromJson (within ProfileSwitchExtension.kt) returns null if icfg is missing within json. We can increase "tolerance" to missing insulin with an ICfg created using default insulin (for peak value) and dia from json file (but pureProfileFromJson signature should be updated to include either activeProfile or default ICfg value within parameters...)
  • in draft PR Draft single InsulinPlugin proposal, with Insulin selection within Profile plugin #3782 I included activeProfile parameter within pureProfileFromJson extension ;-)

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant