-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update composer json #287
base: master
Are you sure you want to change the base?
Update composer json #287
Conversation
(cherry picked from commit a11d56a)
02bd1a1
to
e5198e2
Compare
e5198e2
to
4826c57
Compare
@@ -52,5 +56,10 @@ | |||
"branch-alias": { | |||
"dev-master": "2.0-dev" | |||
} | |||
}, | |||
"scripts": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using make
to handle these.
I'm not opposed to adding the scripts but let's please invoke the appropriate make targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See, I'm running on Windows and the composer scripts allow me to run things without make
.
What exactly would the make targets/parameters translate to in composer context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that we'll now have two places to maintain things.
Make gives us things like defining dependencies and parallelism that composer doesn't, and I don't want migrate away from it.
I know it's inconvenient to install gnu make on windows, but I prefer not to introduce the scripts if we're only repeating the definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added only the basic script calls so that only little maintenance is required, and that they can be run each using the options defined in their respective configuration files. I'd argue that if a toolset changes, it's a non-issue to add/remove it here too.
If one needs to add extra command line options, they can indeed do this via composer and do so from within their favourite IDE:
I find it rather unusual to use make
in a PHP project for tasks that can be done with the built-in tools, in fact, I can't recall seeing this in any other project I`ve used or contributed before.
I've added the missing PHPCS scripts. Heads-up: PHPCBF "conveniently" changes all line endings from CRLF to LF on Windows (not helpful). |
Hi,
in this PR I've added a
scripts
section to thecomposer.json
for convenience and also a link to the list of contributors as authors.Bonus: bumped PHPUnit to v10.5 (ugh, the lock file)