More precise phpdocs #1058
Open
More precise phpdocs #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you are right.. param types should only be done on new major versions. dropped the param type changes |
nikic
reviewed
Jan 1, 2025
| public int $line; | ||
| /** @var int The 0-based starting position of the token (or -1 if unknown). */ | ||
| /** @var int<-1, max> The 0-based starting position of the token (or -1 if unknown). */ |
There was a problem hiding this comment.
Do these types match whatever phpstan specifies for the PhpToken class? As we may either use this class or PhpToken. Not sure which one phpstan would actually pick for analysis...
nicolas-grekas
added a commit
to symfony/polyfill
that referenced
this pull request
Feb 20, 2025
This PR was merged into the 1.x branch. Discussion ---------- More precise phpdocs in PhpToken analog nikic/PHP-Parser#1058 Commits ------- f160585 More precise phpdocs in PhpToken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes a few PHPStan level 7 errors