Fix name context on no namespace #1067
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge 👍 |
nikic
reviewed
Jan 28, 2025
|
the verification of fully qualified already checked before check on line 114, so I think that's safe |
nikic
reviewed
Jan 29, 2025
| @@ -117,8 +117,8 @@ public function testResolveNames(): void { | |||
| new \Hallo\Bar(); | |||
| new \Bar(); | |||
| new \Bar(); | |||
| \bar(); | |||
| \hi(); | |||
| bar(); | |||
There was a problem hiding this comment.
This is what I mean. This should resolve to a fully qualified name. The fact that it is equivalent to the unqualified name doesn't matter, we should always resolve fully if it is possible.
There was a problem hiding this comment.
if i understand correctly, the test is removing namespace, which no longer has namespace, means it doesn't have \\ prefix, next line to it, it have \bar which not changed as already fully qualified on the first place, which expexted.
There was a problem hiding this comment.
see line 124 which kept to have \\ prefix as it previously already fully qualified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://getrector.com/ast/d50f4d493f7061f3c419397a744a49e92409c3ce?nodeId=1
which
\trueshould betrueon no namespace.