-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 #2
Merged
Merged
v4.0.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enum for EventListenerIdDedupeMode.
…erIdDedupeMode. Update docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPDATES:
npm run test-perf
.627 B
when minified and gzipped.npm run test-size
.null
andundefined
.getId
option to Emitter, which allows you to define the function that creates a new event listener id for the Emitter instance by default.BREAKING CHANGES:
627 B
when minified and gzipped.allowDuplicateListeners
option and property fromEmitter
.EmitterDedupe
object which you can use as an enum. And also remove exportedEventListenerIdDedupeMode
type asEmitterDedupe
replaces it.idDedupeMode
option and property to just simplydedupe
as there's no listener based deduping anymore..once()
behaviour to be in line with other emitters. Previously we removed all the once listeners on.emit()
before we started looping and calling the listeners. While this worked fine it caused the once listeners to be called in a different order than one might be accustomed to if you would add and emit once listeners within a once listener. Now the once listeners are removed right before they are called, which is more in line what one might expect.