(belated) review feedback

niloc132 · Dec 13, 2023 · 0a91c0d · 0a91c0d
1 parent 85b5bf5
commit 0a91c0d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,7 +1,6 @@
 name: Build gwt-site-webapp
 on:
   push:
-    branches: ['main']
   pull_request:
 
 jobs:
@@ -17,10 +16,10 @@ jobs:
           cache: 'maven'
 
       - name: Compile the webapp to JS
-        run: mvn --batch-mode -e verify
+        run: mvn --batch-mode --no-transfer-progress -e verify
 
       - name: Upload the generated JS
         uses: actions/upload-artifact@v3
         with:
           name: 'gwt-site-webapp'
-          path: target/gwt-site-webapp-2.0-SNAPSHOT/
+          path: target/gwt-site-webapp-*/
diff --git a/pom.xml b/pom.xml
@@ -47,11 +47,6 @@
             <artifactId>gwt-dev</artifactId>
             <version>${gwt.version}</version>
         </dependency>
-        <dependency>
-            <groupId>com.google.gwt</groupId>
-            <artifactId>gwt-codeserver</artifactId>
-            <version>${gwt.version}</version>
-        </dependency>
     </dependencies>
 
     <build>
@@ -82,6 +77,11 @@
                     <compilerArgs>
                         <arg>-saveSource</arg>
                     </compilerArgs>
+                    <!--
+                    Draft and pretty mode are turned on so that beginners can try out debugging
+                    in their browser with no setup.
+                    Please don't disable this; code size is less important.
+                    -->
                     <draftCompile>true</draftCompile>
                     <style>PRETTY</style>
                     <failOnError>true</failOnError>
@@ -104,7 +104,7 @@
                             <goal>copy-resources</goal>
                         </goals>
                         <configuration>
-                            <outputDirectory>${project.build.directory}/${project.artifactId}-${project.version}/</outputDirectory>
+                            <outputDirectory>${project.build.directory}/${project.build.finalName}/</outputDirectory>
                             <resources>
                                 <!-- copy GWT source code to website for debugging -->
                                 <resource>
@@ -176,7 +176,7 @@
                                     <outputDirectory>${project.build.directory}/www/</outputDirectory>
                                     <resources>
                                         <resource>
-                                            <directory>${project.build.directory}/${project.artifactId}-${project.version}/</directory>
+                                            <directory>${project.build.directory}/${project.build.finalName}/</directory>
                                         </resource>
                                     </resources>
                                 </configuration>