Skip to content

Commit

Permalink
Update assumptions in LoggingRPCSuite and fix missing class name
Browse files Browse the repository at this point in the history
CollectorChrome was renamed about 10 years ago, and sourcemaps are well
supported now, so this test can be adjusted to always handle the
optimized case.
  • Loading branch information
niloc132 committed May 11, 2024
1 parent 468bf52 commit 8868ad5
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions user/test/com/google/gwt/user/LoggingRPCSuite.gwt.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,14 @@
<servlet path='/loggingrpc'
class='com.google.gwt.user.server.rpc.LoggingRPCTestServiceImpl' />

<!-- Enabling sourcemaps will stop JUnit.gwt.xml from using emulated stack mode -->
<set-property name="compiler.useSourceMaps" value="true"/>
<!-- Specify that stack frames can be deduplicated -->
<set-property name="compiler.stackMode" value="strip"/>


<!-- Turn off emulation to test non-sourcemap mode -->
<set-property name="compiler.stackMode" value="native"/>
<!-- when Chrome is enabled, turn off stack trace emulation -->
<set-property name="compiler.stackMode" value="strip">
<when-property-is name="user.agent" value="safari"/>
</set-property>

<!-- when stack trace stripping is enabled, we need to replace the Null collector
<!-- When stack trace stripping is enabled, we need to replace the Null collector
with one that does something -->
<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorChrome">
<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<when-property-is name="compiler.useSourceMaps" value="true" />
</replace-with>

</module>

0 comments on commit 8868ad5

Please sign in to comment.