Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17 #18

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

cdemulde
Copy link

@cdemulde cdemulde commented Dec 6, 2019

This should fix #17, at least it works for the minimal working example provided (#17 (comment)) and the actual code I have.
To be checked though, because I'm not entirely sure of the behaviour of self.last_index and self.reference_counter.

@nilp0inter
Copy link
Owner

Hi, thank you for your contribution. Unfortunately I won't be able to review the issue and the patch until next week. Thank you for your patience.

@cdemulde
Copy link
Author

Hi @nilp0inter,

Have you had the opportunity to consider my above adjustments? Could you let me know whether or not you intend to include them in a new version of experta? Depending on your answer, I code adjust the code of the project I am working on in a future-proof way.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fact can only be modified once based on the fact name
2 participants